linux-kernel - Re: [PATCH v10 3/7] iommu/vt-d: Add domain_flush_pasid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2753b770-564a-b141-1505-94f08016abc5@linux.intel.com>
Date:   Fri, 14 Jul 2023 14:02:19 +0800
From:   Baolu Lu <baolu.lu@...ux.intel.com>
To:     "Tian, Kevin" <kevin.tian@...el.com>,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        Joerg Roedel <joro@...tes.org>,
        Jean-Philippe Brucker <jean-philippe@...aro.com>,
        Robin Murphy <robin.murphy@....com>
Cc:     baolu.lu@...ux.intel.com, Jason Gunthorpe <jgg@...dia.com>,
        Will Deacon <will@...nel.org>,
        "Liu, Yi L" <yi.l.liu@...el.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "Luck, Tony" <tony.luck@...el.com>
Subject: Re: [PATCH v10 3/7] iommu/vt-d: Add domain_flush_pasid_iotlb()

On 2023/7/14 11:51, Tian, Kevin wrote:
>> From: Baolu Lu <baolu.lu@...ux.intel.com>
>> Sent: Friday, July 14, 2023 11:37 AM
>>
>> On 2023/7/13 15:52, Tian, Kevin wrote:
>>>> From: Jacob Pan <jacob.jun.pan@...ux.intel.com>
>>>> Sent: Thursday, July 13, 2023 12:34 AM
>>>> +static void domain_flush_pasid_iotlb(struct intel_iommu *iommu,
>>>> +				     struct dmar_domain *domain, u64 addr,
>>>> +				     unsigned long npages, bool ih)
>>>> +{
>>>> +	u16 did = domain_id_iommu(domain, iommu);
>>>> +	unsigned long flags;
>>>> +
>>>> +	spin_lock_irqsave(&domain->lock, flags);
>>>> +	if (!list_empty(&domain->devices))
>>>> +		qi_flush_piotlb(iommu, did, IOMMU_NO_PASID, addr,
>>>> npages, ih);
>>>> +	spin_unlock_irqrestore(&domain->lock, flags);
>>>
>>> btw I gave a comment before that the check of list_empty() changes
>>> the semantics instead of just creating a helper.
>>>
>>> If it's the right thing to do please split it into a separate fix patch.
>>
>> Perhaps move it into patch 6?
>>
> 
> I still prefer to putting it in a separate patch since it changes the
> behavior in existing path. It's not really about dev_pasid which
> patch6 is trying to support.

Okay, that will also be fine to me.

Best regards,
baolu