[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c9947c45-09e8-e2e1-ea0f-6b6f2fd15594@ti.com>
Date: Fri, 14 Jul 2023 11:41:06 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Andrew Davis <afd@...com>, Vinod Koul <vkoul@...nel.org>
CC: Kishon Vijay Abraham I <kishon@...nel.org>,
Roger Quadros <rogerq@...nel.org>,
<linux-phy@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
<s-vadapalli@...com>
Subject: Re: [PATCH v2] phy: ti: gmii-sel: Allow parent to not be syscon node
On 14/07/23 01:39, Andrew Davis wrote:
> If the parent node is not a syscon type, then fallback and check
> if we can get a regmap from our own node. This no longer forces
> us to make the parent of this node a syscon node when that might
> not be appropriate.
>
> Signed-off-by: Andrew Davis <afd@...com>
Reviewed-by: Siddharth Vadapalli <s-vadapalli@...com>
> ---
>
> Changes from v1:
> - Rebased on v6.5-rc1
>
> drivers/phy/ti/phy-gmii-sel.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c
> index 6286cf25a4264..555b323f45da1 100644
> --- a/drivers/phy/ti/phy-gmii-sel.c
> +++ b/drivers/phy/ti/phy-gmii-sel.c
> @@ -465,9 +465,12 @@ static int phy_gmii_sel_probe(struct platform_device *pdev)
>
> priv->regmap = syscon_node_to_regmap(node->parent);
> if (IS_ERR(priv->regmap)) {
> - ret = PTR_ERR(priv->regmap);
> - dev_err(dev, "Failed to get syscon %d\n", ret);
> - return ret;
> + priv->regmap = device_node_to_regmap(node);
> + if (IS_ERR(priv->regmap)) {
> + ret = PTR_ERR(priv->regmap);
> + dev_err(dev, "Failed to get syscon %d\n", ret);
> + return ret;
> + }
> }
>
> ret = phy_gmii_sel_init_ports(priv);
--
Regards,
Siddharth.
Powered by blists - more mailing lists