linux-kernel - Re: [PATCH] xfs:Comparisons should place the constant on the right side of the test The if statement uses an assignment statement as a condition, which is confusing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZLDsvGI67LzOPp/l@infradead.org>
Date:   Thu, 13 Jul 2023 23:35:40 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     liubin001@...suo.com
Cc:     djwong@...nel.org, linux-xfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs:Comparisons should place the constant on the right
 side of the test The if statement uses an assignment statement as a
 condition, which is confusing.

On Fri, Jul 14, 2023 at 02:26:08PM +0800, liubin001@...suo.com wrote:
> xfs:The if statement uses an assignment statement as a condition, which is
> confusing.
> Signed-off-by: Liu Bin <liubin001@...suo.com>

What's the point?  I prefer the style you change it to as well, but
there is no real downside, and changing code just for the sake of it
causes nothing but churn.