linux-kernel - Re: [PATCH] KVM: arm64:Use #include <linux/kprobes.h> instead of <asm/kprobes.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86r0pbudrb.wl-maz@kernel.org>
Date:   Fri, 14 Jul 2023 08:57:12 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     chenqingyun001@...suo.com
Cc:     oliver.upton@...ux.dev, catalin.marinas@....com, will@...nel.org,
        kvmarm@...ts.linux.dev, linux-kernel@...r.kernel.org,
        james.morse@....com, suzuki.poulose@....com, yuzenghui@...wei.com
Subject: Re: [PATCH] KVM: arm64:Use #include <linux/kprobes.h> instead of <asm/kprobes.h>

On Fri, 14 Jul 2023 05:57:42 +0100,
chenqingyun001@...suo.com wrote:
> 
> Since <asm/kprobes.h> is a kernel-proprietary header file, it
> should not be included by user-space programs.

There is no userspace involved here.

> And <linux/kprobes.h> is a public header file,
> which provides some functions for registering
> and unregistering probes

How is that relevant? Have you checked *why* we're including this
file?

> 
> Signed-off-by: Qingyun Chen <chenqingyun001@...suo.com>
> ---
>  arch/arm64/kvm/hyp/vhe/sysreg-sr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/hyp/vhe/sysreg-sr.c
> b/arch/arm64/kvm/hyp/vhe/sysreg-sr.c
> index b35a178e7e0d..072471df8b1b 100644
> --- a/arch/arm64/kvm/hyp/vhe/sysreg-sr.c
> +++ b/arch/arm64/kvm/hyp/vhe/sysreg-sr.c
> @@ -9,7 +9,7 @@
>  #include <linux/compiler.h>
>  #include <linux/kvm_host.h>
> 
> -#include <asm/kprobes.h>
> +#include <linux/kprobes.h>

And this is at the wrong thing to do.

>  #include <asm/kvm_asm.h>
>  #include <asm/kvm_emulate.h>
>  #include <asm/kvm_hyp.h>
> 

I'd rather you *stop* sending these patches. There is no justification
for them, and you keep doing the wrong thing.

	M.

-- 
Without deviation from the norm, progress is not possible.