linux-kernel - Re: [PATCH] proc: Fix four errors in kmsg.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLEF16qgcTOaLMIk@alley>
Date:   Fri, 14 Jul 2023 10:22:47 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     huzhi001@...suo.com
Cc:     tglx@...utronix.de, senozhatsky@...omium.org, adobriyan@...il.com,
        akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] proc: Fix four errors in kmsg.c

On Fri 2023-07-14 14:57:59, huzhi001@...suo.com wrote:
> The following checkpatch errors are removed:
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo * bar" should be "foo *bar"

Please, do not do fix these cosmetic issues reported by checkpatch.pl.
It is not worth the effort. In fact, it is contra productive.
It complicates the git history, backports.

I suggest to find an area in the kernel which might be interesting
for you (any driver or subsystem, ...) and try to fix a real bug
there or implement a real feature.

You might start with reading the related discussions on lkml or
related mailing list, reviewing or testing patches, ...

Best Regards,
Petr