linux-kernel - Re: 回复: [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 14 Jul 2023 10:41:03 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     杜敏杰 <duminjie@...o.com>
Cc:     Baolu Lu <baolu.lu@...ux.intel.com>,
        Krishna Reddy <vdumpa@...dia.com>,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "open list:TEGRA IOMMU DRIVERS" <linux-tegra@...r.kernel.org>,
        "open list:IOMMU SUBSYSTEM" <iommu@...ts.linux.dev>,
        open list <linux-kernel@...r.kernel.org>,
        "opensource.kernel" <opensource.kernel@...o.com>,
        Thierry Reding <treding@...dia.com>
Subject: Re: 回复: [PATCH v4] iommu: remove redundant parameter check in
 tegra_smmu_debugfs_init()

On Fri, Jul 14, 2023 at 03:21:47AM +0000, 杜敏杰 wrote:
> Hi Baolu!
> 
> It seems that 'smmu->debugfs' check is still needed.
> Then I will modify the patch.
> Thanks!
> 
> regards,
> Minjie

Don't top-post, please. See Documentation/process/2.Process.rst and
Documentation/process/submitting-patches.rst.

Also, how did you come to the above conclusion? Baolu said that Greg
keeps reminding people that we shouldn't do error handling for debugfs
and gave a Reviewed-by:, so why the 180?

Thierry

> -----邮件原件-----
> 发件人: Baolu Lu <baolu.lu@...ux.intel.com> 
> 发送时间: 2023年7月14日 10:58
> 收件人: 杜敏杰 <duminjie@...o.com>; Thierry Reding <thierry.reding@...il.com>; Krishna Reddy <vdumpa@...dia.com>; Joerg Roedel <joro@...tes.org>; Will Deacon <will@...nel.org>; Robin Murphy <robin.murphy@....com>; Jonathan Hunter <jonathanh@...dia.com>; open list:TEGRA IOMMU DRIVERS <linux-tegra@...r.kernel.org>; open list:IOMMU SUBSYSTEM <iommu@...ts.linux.dev>; open list <linux-kernel@...r.kernel.org>
> 抄送: baolu.lu@...ux.intel.com; opensource.kernel <opensource.kernel@...o.com>; Thierry Reding <treding@...dia.com>
> 主题: Re: [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()
> 
> [Some people who received this message don't often get email from baolu.lu@...ux.intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> On 2023/7/13 15:28, Minjie Du wrote:
> > debugfs_create_file() will return early if smmu->debugfs is an error 
> > pointer, so an extra error check is not needed.
> >
> > Signed-off-by: Minjie Du<duminjie@...o.com>
> > Acked-by: Thierry Reding<treding@...dia.com>
> 
> Greg keeps reminding that no error branch for debugfs, so
> 
> Reviewed-by: Lu Baolu <baolu.lu@...ux.intel.com>
> 
> Best regards,
> baolu

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)