linux-kernel - Re: [PATCH] clk: starfive: Simplify .determine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANBLGcz+9V9mWQM6Xt9_F_1q3GhCS0zNisrtYPa=SwNT+tGEyQ@mail.gmail.com>
Date:   Fri, 14 Jul 2023 11:34:14 +0200
From:   Emil Renner Berthing <kernel@...il.dk>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Hal Feng <hal.feng@...rfivetech.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: starfive: Simplify .determine_rate()

On Fri, 7 Jul 2023 at 22:02, Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> jh71x0_clk_mux_determine_rate() is the same as __clk_mux_determine_rate(),
> so use the latter to save some LoC.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Thanks!
Reviewed-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>

> ---
>  drivers/clk/starfive/clk-starfive-jh71x0.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/clk/starfive/clk-starfive-jh71x0.c b/drivers/clk/starfive/clk-starfive-jh71x0.c
> index b372083d11c3..aebc99264a0b 100644
> --- a/drivers/clk/starfive/clk-starfive-jh71x0.c
> +++ b/drivers/clk/starfive/clk-starfive-jh71x0.c
> @@ -174,12 +174,6 @@ static int jh71x0_clk_set_parent(struct clk_hw *hw, u8 index)
>         return 0;
>  }
>
> -static int jh71x0_clk_mux_determine_rate(struct clk_hw *hw,
> -                                        struct clk_rate_request *req)
> -{
> -       return clk_mux_determine_rate_flags(hw, req, 0);
> -}
> -
>  static int jh71x0_clk_get_phase(struct clk_hw *hw)
>  {
>         struct jh71x0_clk *clk = jh71x0_clk_from(hw);
> @@ -261,7 +255,7 @@ static const struct clk_ops jh71x0_clk_gdiv_ops = {
>  };
>
>  static const struct clk_ops jh71x0_clk_mux_ops = {
> -       .determine_rate = jh71x0_clk_mux_determine_rate,
> +       .determine_rate = __clk_mux_determine_rate,
>         .set_parent = jh71x0_clk_set_parent,
>         .get_parent = jh71x0_clk_get_parent,
>         .debug_init = jh71x0_clk_debug_init,
> @@ -271,7 +265,7 @@ static const struct clk_ops jh71x0_clk_gmux_ops = {
>         .enable = jh71x0_clk_enable,
>         .disable = jh71x0_clk_disable,
>         .is_enabled = jh71x0_clk_is_enabled,
> -       .determine_rate = jh71x0_clk_mux_determine_rate,
> +       .determine_rate = __clk_mux_determine_rate,
>         .set_parent = jh71x0_clk_set_parent,
>         .get_parent = jh71x0_clk_get_parent,
>         .debug_init = jh71x0_clk_debug_init,
> --
> 2.34.1
>