linux-kernel - RE: [PATCH net v1] net: ethernet: Remove repeating expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000a01d9b5f5$3591e8b0$a0b5ba10$@trustnetic.com>
Date:   Fri, 14 Jul 2023 09:47:55 +0800
From:   Jiawen Wu <jiawenwu@...stnetic.com>
To:     "'Wang Ming'" <machel@...o.com>,
        "'Mengyuan Lou'" <mengyuanlou@...-swift.com>,
        "'David S. Miller'" <davem@...emloft.net>,
        "'Eric Dumazet'" <edumazet@...gle.com>,
        "'Jakub Kicinski'" <kuba@...nel.org>,
        "'Paolo Abeni'" <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        "'Mengyuan Lou'" <mengyuanlou@...-swift.com>,
        "'David S. Miller'" <davem@...emloft.net>,
        "'Eric Dumazet'" <edumazet@...gle.com>,
        "'Jakub Kicinski'" <kuba@...nel.org>,
        "'Paolo Abeni'" <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Cc:     <opensource.kernel@...o.com>, <opensource.kernel@...o.com>
Subject: RE: [PATCH net v1] net: ethernet: Remove repeating expression

On Thursday, July 13, 2023 8:16 PM, Wang Ming wrote:
> Identify issues that arise by using the tests/doublebitand.cocci
> semantic patch. Need to remove duplicate expression in if statement.
> 
> Signed-off-by: Wang Ming <machel@...o.com>
> ---
>  drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> index 39a9aeee7aab..6321178fc814 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> @@ -1511,7 +1511,6 @@ static void wx_configure_rx(struct wx *wx)
>  	psrtype = WX_RDB_PL_CFG_L4HDR |
>  		  WX_RDB_PL_CFG_L3HDR |
>  		  WX_RDB_PL_CFG_L2HDR |
> -		  WX_RDB_PL_CFG_TUN_TUNHDR |
>  		  WX_RDB_PL_CFG_TUN_TUNHDR;
>  	wr32(wx, WX_RDB_PL_CFG(0), psrtype);

Reviewed-by: Jiawen Wu <jiawenwu@...stnetic.com>