linux-kernel - Re: [PATCH v2] Revert "usb: dwc3: core: Enable AutoRetry feature in the controller"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9ab901161e8c1cc552e8486a847296ce3662be2.camel@gmail.com>
Date:   Fri, 14 Jul 2023 14:28:15 +0200
From:   Jakub Vaněk <linuxtardis@...il.com>
To:     Thinh Nguyen <Thinh.Nguyen@...opsys.com>
Cc:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Mauro Ribeiro <mauro.ribeiro@...dkernel.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v2] Revert "usb: dwc3: core: Enable AutoRetry feature in
 the controller"

Hi Thinh,

On Fri, 2023-07-14 at 00:30 +0000, Thinh Nguyen wrote:
> On Thu, Jul 13, 2023, Jakub Vaněk wrote:
> > Hi Thinh,
> > 
> > On Wed, 2023-07-12 at 22:55 +0000, Thinh Nguyen wrote:
> > > On Thu, Jul 13, 2023, Jakub Vanek wrote:
> > > > This reverts commit b138e23d3dff90c0494925b4c1874227b81bddf7.
> > > > 
> > > > AutoRetry has been found to cause some issues. This feature
> > > > allows
> > > > the controller in host mode (further referred to as the xHC) to
> > > > send
> > > > non-terminating/burst retry ACKs (Retry=1 and Nump!=0) instead
> > > > of
> > > > terminating retry ACKs (Retry=1 and Nump=0) to devices when
> > > > a transaction error occurs.
> > > > 
> > > > Unfortunately, some USB devices fail to retry transactions when
> > > > the xHC sends them a burst retry ACK. When this happens, the
> > > > xHC
> > > 
> > > For some clarity: if the device continues to respond with CRC
> > > error,
> > > the xHC will not complete endpoint related commands while it
> > > keeps
> > > autoretry.
> > 
> > Acknowledged. Do you think it it would be better to respin this
> > patch
> > once more to include this in the changelog?
> > 
> 
> It'll be better to provide more detail. However, I'm fine whether you
> want to send v3 with this or not.

The urge to scratch the itch was too strong :D I have sent a v3 in
https://lore.kernel.org/linux-usb/20230714122419.27741-1-linuxtardis@gmail.com/
with an updated changelog.

> 
> Thanks,
> Thinh

Thanks,
Jakub