linux-kernel - Re: [PATCH v4] serial: 8250_dw: Preserve original value of DLF register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLFAD8lblUA6/cVd@smile.fi.intel.com>
Date:   Fri, 14 Jul 2023 15:31:11 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     Ruihong Luo <colorsu1922@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        stable@...r.kernel.org, luoruihong@...omi.com,
        weipengliang@...omi.com, wengjinfei@...omi.com
Subject: Re: [PATCH v4] serial: 8250_dw: Preserve original value of DLF
 register

On Fri, Jul 14, 2023 at 03:07:42PM +0300, Ilpo Järvinen wrote:
> On Thu, 13 Jul 2023, Ruihong Luo wrote:
> 
> > Preserve the original value of the Divisor Latch Fraction (DLF) register.
> > When the DLF register is modified without preservation, it can disrupt
> > the baudrate settings established by firmware or bootloader, leading to
> > data corruption and the generation of unreadable or distorted characters.
> > 
> > Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

> You forgot to add:
> 
> Cc: stable@...r.kernel.org

It's there. Just not in the commit message. It's fine.

> > Signed-off-by: Ruihong Luo <colorsu1922@...il.com>
> 
> Other than that,
> 
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko