linux-kernel - Re: [PATCH v3 15/15] ASoC: Intel: sst: Convert to PCI device IDs defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLFCWKqiaJZhx6ci@smile.fi.intel.com>
Date:   Fri, 14 Jul 2023 15:40:56 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH v3 15/15] ASoC: Intel: sst: Convert to PCI device IDs
 defines

On Fri, Jul 14, 2023 at 10:24:57PM +0200, Amadeusz Sławiński wrote:
> Use PCI device IDs from pci_ids.h header. BSW replaces CHV, as 0x22a8
> was added in PCI header as BSW ID for consistency, as they are same
> (similar) platforms. The ACPI IDs are used only internally and lower
> 16 bits uniquely define the device as vendor ID for Intel is 8086 for
> all of them. Use PCI_DEVICE_DATA() to match PCI device to be consistent
> with other Intel audio drivers.

One nit-pick below, otherwise
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

...

> -	unsigned int		dev_id;
> +	unsigned short		dev_id;

Thinking more about this change I would probably add a comment on top of
sst_alloc_drv_context() call in sst_acpi.c to tell that in this case the
driver handles PCI IDs in ACPI and we are using only device ID part.
(If real ACPI ID appears, the kstrtouint() returns error, so we are fine
 with the change)

So, summarize above and add a comment.

-- 
With Best Regards,
Andy Shevchenko