linux-kernel - Re: [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61f31b3e-b618-88db-a07c-f6761c1c7d06@linux.intel.com>
Date:   Fri, 14 Jul 2023 10:31:26 +0800
From:   Baolu Lu <baolu.lu@...ux.intel.com>
To:     Minjie Du <duminjie@...o.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Krishna Reddy <vdumpa@...dia.com>,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "open list:TEGRA IOMMU DRIVERS" <linux-tegra@...r.kernel.org>,
        "open list:IOMMU SUBSYSTEM" <iommu@...ts.linux.dev>,
        open list <linux-kernel@...r.kernel.org>
Cc:     baolu.lu@...ux.intel.com, opensource.kernel@...o.com,
        Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH v4] iommu: remove redundant parameter check in
 tegra_smmu_debugfs_init()

On 2023/7/13 15:28, Minjie Du wrote:
> debugfs_create_file() will return early if smmu->debugfs is an error
> pointer, so an extra error check is not needed.
> 
> Signed-off-by: Minjie Du <duminjie@...o.com>
> Acked-by: Thierry Reding <treding@...dia.com>
> ---
>   drivers/iommu/tegra-smmu.c | 2 --
>   1 file changed, 2 deletions(-)

Next time when you send a new version of a patch, please don't forget to
add the change log after the tear line. This way, people can know how
the patch evolved into this way.

Best regards,
baolu

> 
> diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
> index 1cbf063cc..2137040b7 100644
> --- a/drivers/iommu/tegra-smmu.c
> +++ b/drivers/iommu/tegra-smmu.c
> @@ -1056,8 +1056,6 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients);
>   static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu)
>   {
>   	smmu->debugfs = debugfs_create_dir("smmu", NULL);
> -	if (!smmu->debugfs)
> -		return;
>   
>   	debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu,
>   			    &tegra_smmu_swgroups_fops);