linux-kernel - Re: [PATCH v2 3/6] net: phy: at803x: enable qca8081 slave seed conditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2ea830d-6444-47d6-8a0d-48098f1b954e@lunn.ch>
Date:   Fri, 14 Jul 2023 15:16:36 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Luo Jie <quic_luoj@...cinc.com>
Cc:     hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/6] net: phy: at803x: enable qca8081 slave seed
 conditionally

On Fri, Jul 14, 2023 at 02:31:33PM +0800, Luo Jie wrote:
> qca8081 is the single port PHY, the slave prefer mode is used
> by default.
> 
> if the phy master perfer mode is configured, the slave seed
> configuration should not be enabled, since the slave seed
> enablement ignores the master/slave perfer configuration,
> which is not expected.
> 
> disable slave seed if the master mode is preferred.
> 
> Signed-off-by: Luo Jie <quic_luoj@...cinc.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew