linux-kernel - Re: [PATCH v1] ASoC: tas2505: Add tas2505 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9358b427-faa7-48be-b386-bf1287906873@sirena.org.uk>
Date:   Fri, 14 Jul 2023 14:46:27 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Kevin Lu <luminlong@....com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        kevin-lu@...com, shenghao-ding@...com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] ASoC: tas2505: Add tas2505 driver

On Wed, Jul 12, 2023 at 12:43:21PM +0800, Kevin Lu wrote:

> +	val = (ucontrol->value.integer.value[0] & 0x7f);
> +	val = mc->invert ? mc->max - val : val;
> +	val = (val < 0) ? 0 : val;

Please write normal if statements, it helps with legibility.

> +	.num_reg_defaults = ARRAY_SIZE(tas2505_reg_defaults),
> +	.cache_type = REGCACHE_RBTREE,

Please use REGCACHE_MAPLE for new devices where you'd otherwise have
used RBTREE unless there's a particular reason - it's more modern.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)