linux-kernel - Re: [PATCH v3] ntb: Remove error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5d0cd0e0-d92e-42d3-a6d9-ec9fc3229b7b@kadam.mountain>
Date:   Fri, 14 Jul 2023 17:08:24 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Serge Semin <fancer.lancer@...il.com>, Wang Ming <machel@...o.com>,
        opensource.kernel@...o.com, kernel-janitors@...r.kernel.org,
        ntb@...ts.linux.dev, Allen Hubbe <allenbh@...il.com>,
        Dan Carpenter <error27@...il.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Jiasheng Jiang <jiasheng@...as.ac.cn>,
        Jon Mason <jdmason@...zu.us>,
        LKML <linux-kernel@...r.kernel.org>,
        Minjie Du <duminjie@...o.com>
Subject: Re: [PATCH v3] ntb: Remove error checking for debugfs_create_dir()

On Fri, Jul 14, 2023 at 02:44:11PM +0200, Markus Elfring wrote:
> > > It is expected that most callers should _ignore_ the errors
> > > return by debugfs_create_dir() in tool_setup_dbgfs()
> …
> > The patch itself is correct for sure:
> > Reviewed-by: Serge Semin <fancer.lancer@...il.com>
> 
> How does such information fit to the Linux development requirement
> for imperative change descriptions?
> 

Markus, you already replied to this thread.

Greg, HCH, Matthew Wilcox and Krzysztof Kozlowski have all asked you to
stop.  Those are respected kernel maintainers.  You should listen to
them.

If you see a bug, that's useful.  But if you're just nitpicking the
commit message, that's not useful.  We have explained this many times as
clearly as we know how.

> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94
> 
> 
> How do you think about to add the tag “Fixes” because of the deletion
> of an inappropriate error detection?

No.  It's not a bug fix so a Fixes tag is innappropriate.

regards,
dan carpenter