linux-kernel - Re: [PATCH] kbuild: Enable -Wenum-conversion by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNARbt-=KnmA+pTJQ1Fg9XmGMySWAFd1jDs_smnpq1Nus7w@mail.gmail.com>
Date:   Sat, 15 Jul 2023 14:46:19 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Nathan Chancellor <nathan@...nel.org>
Cc:     Borislav Petkov <bp@...en8.de>, linux-kbuild@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: Enable -Wenum-conversion by default

On Thu, Jul 6, 2023 at 1:20 AM Nathan Chancellor <nathan@...nel.org> wrote:
>
> On Wed, Jul 05, 2023 at 12:19:51AM +0200, Borislav Petkov wrote:
> > From: "Borislav Petkov (AMD)" <bp@...en8.de>
> >
> > This diagnostic checks whether there is a type mismatch when
> > converting enums (assign an enum of type A to an enum of type B, for
> > example) and it caught a legit issue recently. The reason it didn't show
> > is because that warning is enabled only with -Wextra with GCC. Clang,
> > however, enables it by default.
> >
> > GCC folks were considering enabling it by default but it was too noisy
> > back then:
> >
> >   https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78736
> >
> > Now that due to clang all those warnings have been fixed, enable it with
> > GCC too.
> >
> > allmodconfig tests done with: x86, arm{,64}, powerpc{,64}, riscv
> > crossbuilds.
> >
> > Signed-off-by: Borislav Petkov (AMD) <bp@...en8.de>
>
> Yes please :)
>
> Reviewed-by: Nathan Chancellor <nathan@...nel.org>
>




Applied to linux-kbuild.
Thanks.






-- 
Best Regards
Masahiro Yamada