linux-kernel - Re: [PATCH] fs: inode: return proper errno on bmap()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 15 Jul 2023 15:49:54 +0900
From:   Leesoo Ahn <lsahn@...akecorp.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     LKML <linux-kernel@...r.kernel.org>, linux-fsdevel@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>
Subject: Re: [PATCH] fs: inode: return proper errno on bmap()



2023-07-15 오후 3:39에 Markus Elfring 이(가) 쓴 글:
>  > It better returns -EOPNOTSUPP instead of -EINVAL which has meaning of
>  > the argument is an inappropriate value. It doesn't make sense in the
>  > case of that a file system doesn't support bmap operation.
>  >
>  > -EINVAL could make confusion in the userspace perspective.
> 
> Are imperative change descriptions still preferred?
> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94
> 
> 
> How do you think about to use a subject like “[PATCH v2] fs: inode:
> Return proper error code in bmap()”?
> 
> 
> Please reconsider also the distribution of addresses in recipient lists.
> https://lore.kernel.org/lkml/20230715060217.1469690-1-lsahn@wewakecorp.com/
> 
> Regards,
> Markus

Thank you for the feedback.
I will post v2 patch soon

best regards,
Leesoo