linux-kernel - Re: [PATCH v2] wifi: rtw89: debug: fix error code in rtw89_debug_priv_btc_manual

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <tencent_283F851E543C098B9BC8DAA32D79B00A0F07@qq.com>
Date:   Sat, 15 Jul 2023 17:56:10 +0800
From:   Zhang Shurong <zhang_shurong@...mail.com>
To:     linux-wireless@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        Kalle Valo <kvalo@...nel.org>,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Markus Elfring <Markus.Elfring@....de>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] wifi: rtw89: debug: fix error code in
 rtw89_debug_priv_btc_manual_set

在 2023年7月15日星期六 CST 下午5:22:08，Markus Elfring 写道：
> > If there is a failure during kstrtobool_from_user()
> > rtw89_debug_priv_btc_manual_set should return negative error code
> > instead of returning the count driectly.
> > 
> > Fix this bug by returning the correct error code.
> 
> How do you think about to use an other wording approach
> (like the following) for an improved change description?
> 
> 
>   Return an error code instead of a count after a failed call
>   of the function “kstrtobool_from_user”.
>   Omit the label “out” with this source code correction.
> 
> 
> Regards,
> Markus
Thanks for your kindness reply and advice and I will change my description
in the next version.

Regards,
Shurong