linux-kernel - Re: [PATCH V1] scsi: ufs: ufs-qcom: Update UFS devfreq Parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0cf2a0f4-7f5d-78d5-0004-57c446adc883@linaro.org>
Date:   Sat, 15 Jul 2023 16:09:24 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Nitin Rawat <quic_nitirawa@...cinc.com>, mani@...nel.org,
        quic_cang@...cinc.com, stanley.chu@...iatek.com,
        bvanassche@....org, quic_asutoshd@...cinc.com, avri.altman@....com,
        martin.petersen@...cle.com, beanhuo@...ron.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        agross@...nel.org, andersson@...nel.org, jejb@...ux.ibm.com,
        linux-arm-msm@...r.kernel.org, quic_ziqichen@...cinc.com
Subject: Re: [PATCH V1] scsi: ufs: ufs-qcom: Update UFS devfreq Parameters

On 11.07.2023 12:40, Nitin Rawat wrote:
> To support the periodic polling mode without stop
> caused by CPU idle state, enable delayed timer
> as default instead of deferrable timer for
> qualcomm platforms.
> And change UFS devfreq downdifferential threshold to 65
> for less aggresive downscaling.
Please wrap your commit messages at around 70 characters, 50
makes it very hard to read.

Konrad
> 
> Signed-off-by: Nitin Rawat <quic_nitirawa@...cinc.com>
> Signed-off-by: Asutosh Das <quic_asutoshd@...cinc.com>
> ---
>  drivers/ufs/host/ufs-qcom.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 82d02e7f3b4f..a15815c951ca 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1388,8 +1388,9 @@ static void ufs_qcom_config_scaling_param(struct ufs_hba *hba,
>  					struct devfreq_simple_ondemand_data *d)
>  {
>  	p->polling_ms = 60;
> +	p->timer = DEVFREQ_TIMER_DELAYED;
>  	d->upthreshold = 70;
> -	d->downdifferential = 5;
> +	d->downdifferential = 65;
>  }
>  #else
>  static void ufs_qcom_config_scaling_param(struct ufs_hba *hba,
> --
> 2.17.1
>