linux-kernel - Re: [PATCH v2] fs: inode: return proper error code in bmap()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLKzl+Ac+px98GwC@casper.infradead.org>
Date:   Sat, 15 Jul 2023 15:56:23 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Leesoo Ahn <lsahn@...eel.net>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Leesoo Ahn <lsahn@...akecorp.com>
Subject: Re: [PATCH v2] fs: inode: return proper error code in bmap()

On Sat, Jul 15, 2023 at 05:22:04PM +0900, Leesoo Ahn wrote:
> Return -EOPNOTSUPP instead of -EINVAL which has the meaning of

EOPNOTSUPP is the wrong errno.  ENOTTY is "more" correct.

By the way, don't send v2 just because Markus has picked at a nit.
Wait for substantive feedback.