linux-kernel - Re: [PATCH] hwmon: bt1-pvt: Convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0408d4f-3569-4a60-8cf6-8fdd40c3cbf7@roeck-us.net>
Date:   Sat, 15 Jul 2023 10:01:46 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Yangtao Li <frank.li@...o.com>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: bt1-pvt: Convert to
 devm_platform_ioremap_resource()

On Tue, Jul 04, 2023 at 05:43:06PM +0800, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/bt1-pvt.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/hwmon/bt1-pvt.c b/drivers/hwmon/bt1-pvt.c
> index 8d402a627306..b77ebac2e0ce 100644
> --- a/drivers/hwmon/bt1-pvt.c
> +++ b/drivers/hwmon/bt1-pvt.c
> @@ -891,15 +891,8 @@ static struct pvt_hwmon *pvt_create_data(struct platform_device *pdev)
>  static int pvt_request_regs(struct pvt_hwmon *pvt)
>  {
>  	struct platform_device *pdev = to_platform_device(pvt->dev);
> -	struct resource *res;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		dev_err(pvt->dev, "Couldn't find PVT memresource\n");
> -		return -EINVAL;
> -	}
> -
> -	pvt->regs = devm_ioremap_resource(pvt->dev, res);
> +	pvt->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(pvt->regs))
>  		return PTR_ERR(pvt->regs);
>