linux-kernel - RE: [PATCH] drm/radeon: ERROR: "foo* bar" should be "foo *bar"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN2PR12MB4128493974ADD3F52EE304119035A@MN2PR12MB4128.namprd12.prod.outlook.com>
Date:   Sat, 15 Jul 2023 05:10:21 +0000
From:   "SHANMUGAM, SRINIVASAN" <SRINIVASAN.SHANMUGAM@....com>
To:     "shijie001@...suo.com" <shijie001@...suo.com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        "airlied@...il.com" <airlied@...il.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drm/radeon: ERROR: "foo* bar" should be "foo *bar"

[Public]

Reviewed-by: Srinivasan Shanmugam <srinivasan.shanmugam@....com>

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@...ts.freedesktop.org> On Behalf Of shijie001@...suo.com
Sent: Friday, July 14, 2023 1:36 PM
To: Deucher, Alexander <Alexander.Deucher@....com>; Pan, Xinhui <Xinhui.Pan@....com>; airlied@...il.com; daniel@...ll.ch
Cc: dri-devel@...ts.freedesktop.org; amd-gfx@...ts.freedesktop.org; linux-kernel@...r.kernel.org
Subject: [PATCH] drm/radeon: ERROR: "foo* bar" should be "foo *bar"

Fix five occurrences of the checkpatch.pl error:
ERROR: "foo* bar" should be "foo *bar"
ERROR: that open brace { should be on the previous line

Signed-off-by: Jie Shi <shijie001@...suo.com>
---
  drivers/gpu/drm/radeon/radeon_audio.c | 11 +++++------
  1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_audio.c
b/drivers/gpu/drm/radeon/radeon_audio.c
index d6ccaf24ee0c..a010bc2c155c 100644
--- a/drivers/gpu/drm/radeon/radeon_audio.c
+++ b/drivers/gpu/drm/radeon/radeon_audio.c
@@ -35,15 +35,14 @@

  void dce6_audio_enable(struct radeon_device *rdev, struct r600_audio_pin *pin,
          u8 enable_mask);
-struct r600_audio_pin* r600_audio_get_pin(struct radeon_device *rdev); -struct r600_audio_pin* dce6_audio_get_pin(struct radeon_device *rdev);
+struct r600_audio_pin *r600_audio_get_pin(struct radeon_device *rdev);
+struct r600_audio_pin *dce6_audio_get_pin(struct radeon_device *rdev);
  static void radeon_audio_hdmi_mode_set(struct drm_encoder *encoder,
      struct drm_display_mode *mode);
  static void radeon_audio_dp_mode_set(struct drm_encoder *encoder,
      struct drm_display_mode *mode);

-static const u32 pin_offsets[7] =
-{
+static const u32 pin_offsets[7] = {
      (0x5e00 - 0x5e00),
      (0x5e18 - 0x5e00),
      (0x5e30 - 0x5e00),
@@ -359,7 +358,7 @@ static void radeon_audio_write_latency_fields(struct
drm_encoder *encoder,
          radeon_encoder->audio->write_latency_fields(encoder, connector, mode);
  }

-struct r600_audio_pin* radeon_audio_get_pin(struct drm_encoder
*encoder)
+struct r600_audio_pin *radeon_audio_get_pin(struct drm_encoder
*encoder)
  {
      struct radeon_device *rdev = encoder->dev->dev_private;
      struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder); @@ -526,7 +525,7 @@ static void radeon_audio_calc_cts(unsigned int clock, int *CTS, int *N, int freq
          *N, *CTS, freq);
  }

-static const struct radeon_hdmi_acr* radeon_audio_acr(unsigned int
clock)
+static const struct radeon_hdmi_acr *radeon_audio_acr(unsigned int
clock)
  {
      static struct radeon_hdmi_acr res;
      u8 i;