linux-kernel - Re: [PATCH v3] HID: hid-google-stadiaff: add support for Stadia force feedback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLQ5XMobES0r6Fel@google.com>
Date:   Sun, 16 Jul 2023 18:39:24 +0000
From:   Fabio Baltieri <fabiobaltieri@...omium.org>
To:     Rahul Rameshbabu <rrameshbabu@...dia.com>
Cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jiri Kosina <jikos@...nel.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] HID: hid-google-stadiaff: add support for Stadia
 force feedback

Hi Rahul,

On Fri, Jul 14, 2023 at 02:13:34PM -0700, Rahul Rameshbabu wrote:
> On Sun, 09 Jul, 2023 21:44:10 +0000 Fabio Baltieri <fabiobaltieri@...omium.org> wrote:
> > Add a hid-stadiaff module to support rumble based force feedback on the
> > Google Stadia controller. This works using the HID output endpoint
> > exposed on both the USB and BLE interface.
> >
> > Signed-off-by: Fabio Baltieri <fabiobaltieri@...omium.org>
> > ---
> > +static int stadia_probe(struct hid_device *hdev, const struct hid_device_id *id)
> > +{
> > +	int ret;
> > +
> > +	ret = hid_parse(hdev);
> > +	if (ret) {
> > +		hid_err(hdev, "parse failed\n");
> > +		return ret;
> > +	}
> > +
> > +	ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT & ~HID_CONNECT_FF);
> > +	if (ret) {
> > +		hid_err(hdev, "hw start failed\n");
> > +		return ret;
> > +	}
> > +
> > +	ret = stadiaff_init(hdev);
> > +	if (ret) {
> > +		dev_err(&hdev->dev, "force feedback init failed\n");
> 
> Error handling looks good to me now. Is there any particular reason you
> use dev_err here instead of hid_err here?

Not really, copied from another hid driver and did not realize the
inconsistency. I'll fix that up and send a v4.

Thanks again for spotting this!

Fabio