linux-kernel - Re: [PATCH] HID: hiddev: Modify Format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023071623-shrouded-slacker-97a8@gregkh>
Date:   Sun, 16 Jul 2023 07:39:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     wuyonggang001@...suo.com
Cc:     jikos@...nel.org, benjamin.tissoires@...hat.com,
        linux-usb@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: hiddev: Modify Format

On Sun, Jul 16, 2023 at 12:11:11PM +0800, wuyonggang001@...suo.com wrote:
> Fix the following checkpatch error(s):
> 
> ERROR: "inode * inode" should be "inode *inode"
> ERROR: "file * file" should be "file *file"
> 
> Signed-off-by: Libing Zhang <zhanglibing@...rlc.com>
> ---
>  drivers/hid/usbhid/hiddev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
> index 59cf3ddfdf78..581dc33197d0 100644
> --- a/drivers/hid/usbhid/hiddev.c
> +++ b/drivers/hid/usbhid/hiddev.c
> @@ -213,7 +213,7 @@ static int hiddev_fasync(int fd, struct file *file, int
> on)
>  /*
>   * release file op
>   */
> -static int hiddev_release(struct inode * inode, struct file * file)
> +static int hiddev_release(struct inode *inode, struct file *file)
>  {
>      struct hiddev_list *list = file->private_data;
>      unsigned long flags;

This patch is corrupted and can not be applied.

Please try working on drivers/staging/* files instead first, to give you
a chance to figure out how to do kernel development, before attempting
checkpatch changes on subsystems that might not want them.

good luck!

greg k-h