linux-kernel - RE: [PATCH 10/10] spi: rzv2m-csi: Make use of device_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYWPR01MB8775AF94C79B3C107E442696C23BA@TYWPR01MB8775.jpnprd01.prod.outlook.com>
Date:   Mon, 17 Jul 2023 15:05:31 +0000
From:   Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Mark Brown <broonie@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH 10/10] spi: rzv2m-csi: Make use of device_set_node

Hi Andy,

> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Subject: Re: [PATCH 10/10] spi: rzv2m-csi: Make use of device_set_node
> 
> On Sat, Jul 15, 2023 at 4:04 AM Fabrizio Castro
> <fabrizio.castro.jz@...esas.com> wrote:
> >
> > Use device_set_node instead of assigning controller->dev.of_node
> > directly.
> 
> "...because it also sets the firmware node."
> 
> You probably need to add property.h, if not added yet.

You are right, I'll send a v2 for this.
I'll also add the related Suggested-by and Reviewed-by tags in v2.

Cheers,
Fab

> 
> --
> With Best Regards,
> Andy Shevchenko