linux-kernel - Re: [PATCH] fb: Explicitly include correct DT includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqJ2bkBU0WQG2jt755c_V4x4uR36Dvt2qEeXv52zCWeUmw@mail.gmail.com>
Date:   Mon, 17 Jul 2023 09:22:10 -0600
From:   Rob Herring <robh@...nel.org>
To:     Thomas Zimmermann <tzimmermann@...e.de>
Cc:     Helge Deller <deller@....de>, Michal Simek <michal.simek@....com>,
        devicetree@...r.kernel.org, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] fb: Explicitly include correct DT includes

On Sat, Jul 15, 2023 at 12:34 PM Thomas Zimmermann <tzimmermann@...e.de> wrote:
>
> Hi
>
> Am 14.07.23 um 19:50 schrieb Rob Herring:
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it as merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
> >
> > Signed-off-by: Rob Herring <robh@...nel.org>
> [...]
> >
> > @@ -48,7 +48,7 @@ int sbusfb_mmap_helper(struct sbus_mmap_map *map,
> >       unsigned long map_offset = 0;
> >       unsigned long off;
> >       int i;
> > -
> > +
>
> The various whitespace fixes should rather go into a separate patch. You
> can add
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>
>
> to the whitespace fix and the include cleanup.

Indeed. I missed dropping the whitespace change.

Rob