linux-kernel - Re: [PATCH] i2c: tegra: Fix the check during DMA channel release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLVdHzFm8yngLDj2@orome>
Date:   Mon, 17 Jul 2023 17:24:15 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Akhil R <akhilrajeev@...dia.com>
Cc:     christian.koenig@....com, digetx@...il.com, jonathanh@...dia.com,
        ldewangan@...dia.com, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        sumit.semwal@...aro.org, wsa@...nel.org
Subject: Re: [PATCH] i2c: tegra: Fix the check during DMA channel release

On Mon, Jul 17, 2023 at 08:42:40PM +0530, Akhil R wrote:
> Check for error and NULL before attempting to release DMA channel.
> 
> This, otherwise, was causing panic and crash in kernel when the
> dma_chan has an invalid value. The condition occurs during init_dma()
> when the dma_request_chan() function returns an error.
> 
> Fixes: fcc8a89a1c83 ("i2c: tegra: Share same DMA channel for RX and TX")
> Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> ---
>  drivers/i2c/busses/i2c-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

There's already another patch on the list that should address this:

	https://patchwork.ozlabs.org/project/linux-tegra/patch/20230707132619.2998382-1-thierry.reding@gmail.com/

Can you please test and provide feedback on that one?

Thanks,
Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)