linux-kernel - Re: [PATCH] wcn36xx: remove space before ')'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31018c49-44bc-5930-6c86-e1be95d71dc3@quicinc.com>
Date:   Mon, 17 Jul 2023 08:28:10 -0700
From:   Jeff Johnson <quic_jjohnson@...cinc.com>
To:     <hanyu001@...suo.com>, <kvalo@...nel.org>
CC:     <linux-wireless@...r.kernel.org>, <wcn36xx@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wcn36xx: remove space before ')'

On 7/17/2023 12:04 AM, hanyu001@...suo.com wrote:
> Fixes checkpatch.pl error:
> 
> ./drivers/net/wireless/ath/wcn36xx/dxe.c:470: ERROR: space prohibited 
> before that close parenthesis ')'
> ./drivers/net/wireless/ath/wcn36xx/dxe.c:509: ERROR: space prohibited 
> before that close parenthesis ')'
> 
> Signed-off-by: maqimei <2433033762@...com>

For all of your recent patches you have the issue that your 
Signed-off-by does not seem to be a legal name, and that it does not 
match the From address in your e-mail.

Refer to 
<https://www.kernel.org/doc/html/latest/process/submitting-patches.html?highlight=signed%20off#sign-your-work-the-developer-s-certificate-of-origin>

Also all wifi drivers should have a subject prefix of "wifi: 
<drivername>:", in this case "wifi: wcn36xx: "

The actual patch LGTM

> ---
>   drivers/net/wireless/ath/wcn36xx/dxe.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/wcn36xx/dxe.c 
> b/drivers/net/wireless/ath/wcn36xx/dxe.c
> index 9013f05..b8d7676 100644
> --- a/drivers/net/wireless/ath/wcn36xx/dxe.c
> +++ b/drivers/net/wireless/ath/wcn36xx/dxe.c
> @@ -467,7 +467,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, 
> void *dev)
>                          WCN36XX_DXE_0_INT_CLR,
>                          WCN36XX_INT_MASK_CHAN_TX_H);
> 
> -        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) {
> +        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) {
>               wcn36xx_dxe_write_register(wcn,
>                              WCN36XX_DXE_0_INT_ERR_CLR,
>                              WCN36XX_INT_MASK_CHAN_TX_H);
> @@ -506,7 +506,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, 
> void *dev)
>                          WCN36XX_DXE_0_INT_CLR,
>                          WCN36XX_INT_MASK_CHAN_TX_L);
> 
> -        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) {
> +        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) {
>               wcn36xx_dxe_write_register(wcn,
>                              WCN36XX_DXE_0_INT_ERR_CLR,
>                              WCN36XX_INT_MASK_CHAN_TX_L);