linux-kernel - Re: [PATCH] media: rkvdec: increase max supported height for H.264

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7046e828625a2acd97c48aec9f3b0ef0cc4930ed.camel@collabora.com>
Date:   Mon, 17 Jul 2023 11:45:04 -0400
From:   Nicolas Dufresne <nicolas.dufresne@...labora.com>
To:     Benjamin Gaignard <benjamin.gaignard@...labora.com>,
        ezequiel@...guardiasur.com.ar, mchehab@...nel.org,
        gregkh@...uxfoundation.org
Cc:     linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH] media: rkvdec: increase max supported height for H.264

Le lundi 17 juillet 2023 à 17:06 +0200, Benjamin Gaignard a écrit :
> After testing it is possible for the hardware to decode H264
> bistream with a height up to 2560.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...labora.com>

Thanks, this could possibly have a Fixes tag ?
Fixes: cd33c830448ba ("media: rkvdec: Add the rkvdec driver")

With or without the that though:
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

> ---
>  drivers/staging/media/rkvdec/rkvdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
> index 134e2b9fa7d9..84a41792cb4b 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.c
> +++ b/drivers/staging/media/rkvdec/rkvdec.c
> @@ -120,7 +120,7 @@ static const struct rkvdec_coded_fmt_desc rkvdec_coded_fmts[] = {
>  			.max_width = 4096,
>  			.step_width = 16,
>  			.min_height = 48,
> -			.max_height = 2304,
> +			.max_height = 2560,
>  			.step_height = 16,
>  		},
>  		.ctrls = &rkvdec_h264_ctrls,