| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <87acbb49fa83b0e3f261315a531e105da9e5b9d6.camel@intel.com>
Date: Mon, 17 Jul 2023 15:55:50 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "broonie@...nel.org" <broonie@...nel.org>
CC: "Schimpe, Christina" <christina.schimpe@...el.com>,
"Yang, Weijiang" <weijiang.yang@...el.com>,
"hjl.tools@...il.com" <hjl.tools@...il.com>,
"x86@...nel.org" <x86@...nel.org>,
"monstr@...str.eu" <monstr@...str.eu>,
"rppt@...nel.org" <rppt@...nel.org>,
"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
"linux-snps-arc@...ts.infradead.org"
<linux-snps-arc@...ts.infradead.org>,
"Torvalds, Linus" <torvalds@...ux-foundation.org>,
"kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
"dinguyen@...nel.org" <dinguyen@...nel.org>,
"rdunlap@...radead.org" <rdunlap@...radead.org>,
"tglx@...utronix.de" <tglx@...utronix.de>,
"sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>,
"arnd@...db.de" <arnd@...db.de>,
"linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
"Lutomirski, Andy" <luto@...nel.org>,
"szabolcs.nagy@....com" <szabolcs.nagy@....com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
"pavel@....cz" <pavel@....cz>,
"keescook@...omium.org" <keescook@...omium.org>,
"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
"gorcunov@...il.com" <gorcunov@...il.com>,
"andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>,
"david@...hat.com" <david@...hat.com>,
"hpa@...or.com" <hpa@...or.com>,
"loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>,
"peterz@...radead.org" <peterz@...radead.org>,
"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
"nadav.amit@...il.com" <nadav.amit@...il.com>,
"linux-m68k@...ts.linux-m68k.org" <linux-m68k@...ts.linux-m68k.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"openrisc@...ts.librecores.org" <openrisc@...ts.librecores.org>,
"jamorris@...ux.microsoft.com" <jamorris@...ux.microsoft.com>,
"mike.kravetz@...cle.com" <mike.kravetz@...cle.com>,
"debug@...osinc.com" <debug@...osinc.com>,
"fweimer@...hat.com" <fweimer@...hat.com>,
"kcc@...gle.com" <kcc@...gle.com>,
"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
"mingo@...hat.com" <mingo@...hat.com>,
"linux-csky@...r.kernel.org" <linux-csky@...r.kernel.org>,
"linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
"john.allen@....com" <john.allen@....com>,
"Eranian, Stephane" <eranian@...gle.com>,
"bsingharora@...il.com" <bsingharora@...il.com>,
"linux-alpha@...r.kernel.org" <linux-alpha@...r.kernel.org>,
"linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
"linux-um@...ts.infradead.org" <linux-um@...ts.infradead.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"torvalds@...uxfoundation.org" <torvalds@...uxfoundation.org>,
"bp@...en8.de" <bp@...en8.de>, "corbet@....net" <corbet@....net>,
"linux-hexagon@...r.kernel.org" <linux-hexagon@...r.kernel.org>,
"dethoma@...rosoft.com" <dethoma@...rosoft.com>,
"jannh@...gle.com" <jannh@...gle.com>,
"Syromiatnikov, Eugene" <esyr@...hat.com>,
"oleg@...hat.com" <oleg@...hat.com>,
"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to
pte_mkwrite_novma()
On Fri, 2023-07-14 at 23:57 +0100, Mark Brown wrote:
> On Mon, Jun 12, 2023 at 05:10:27PM -0700, Rick Edgecombe wrote:
> > The x86 Shadow stack feature includes a new type of memory called
> > shadow
> > stack. This shadow stack memory has some unusual properties, which
> > requires
> > some core mm changes to function properly.
>
> This seems to break sparc64_defconfig when applied on top of v6.5-
> rc1:
>
> In file included from /home/broonie/git/bisect/include/linux/mm.h:29,
> from /home/broonie/git/bisect/net/core/skbuff.c:40:
> /home/broonie/git/bisect/include/linux/pgtable.h: In function
> 'pmd_mkwrite':
> /home/broonie/git/bisect/include/linux/pgtable.h:528:9: error:
> implicit declaration of function 'pmd_mkwrite_novma'; did you mean
> 'pte_mkwrite_novma'? [-Werror=implicit-function-declaration]
> return pmd_mkwrite_novma(pmd);
> ^~~~~~~~~~~~~~~~~
> pte_mkwrite_novma
> /home/broonie/git/bisect/include/linux/pgtable.h:528:9: error:
> incompatible types when returning type 'int' but 'pmd_t' {aka 'struct
> <anonymous>'} was expected
> return pmd_mkwrite_novma(pmd);
> ^~~~~~~~~~~~~~~~~~~~~~
>
> The same issue seems to apply with the version that was in -next
> based
> on v6.4-rc4 too.
The version in your branch is not the same as the version in tip (which
had a squashed build fix). I was able to reproduce the build error with
your branch. But not with the one in tip rebased on v6.5-rc1. So can
you try this version:
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/shstk&id=899223d69ce9f338056f4c41ef870d70040fc860
Powered by blists - more mailing lists