[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bc32013a-9f72-6a67-29ed-9a300ea1131e@intel.com>
Date: Mon, 17 Jul 2023 09:09:17 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: <linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
Shaopeng Tan <tan.shaopeng@...fujitsu.com>,
Fenghua Yu <fenghua.yu@...el.com>,
Babu Moger <babu.moger@....com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 04/19] selftests/resctrl: Close perf value read fd on
errors
Hi Ilpo,
On 7/17/2023 6:05 AM, Ilpo Järvinen wrote:
> On Fri, 14 Jul 2023, Reinette Chatre wrote:
>> * add check in get_llc_perf() that it does not attempt ioctl()
>> on "fd_lm == -1" (later addition would be error checking of
>> the ioctl())
>
> The other two things suggested seem unnecessary and I've not implemented
> them, I don't thinkg fd_lm can be -1 at ioctl(). Given this code is going
> to be replaced soonish, putting any extra "safety" effort into it now
> seems waste of time.
Yes, this suggestion was indeed to make the code more robust. I
certainly do not want to waste your time. Please keep in mind
when you respond that I do not have insight into the reworks
you are still planning.
Reinette
Powered by blists - more mailing lists