linux-kernel - Re: [PATCH V4] PCI: qcom: Fixing broken pcie bring up for 2_3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fc238aa-82c1-383a-9dca-72f979ee3c07@quicinc.com>
Date:   Mon, 17 Jul 2023 22:45:42 +0530
From:   Sricharan Ramabadhran <quic_srichara@...cinc.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <robh@...nel.org>, <mani@...nel.org>,
        <lpieralisi@...nel.org>, <bhelgaas@...gle.com>, <kw@...ux.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-pci@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH V4] PCI: qcom: Fixing broken pcie bring up for 2_3_3
 configs ops



On 7/17/2023 7:09 PM, Greg KH wrote:
> On Mon, Jul 17, 2023 at 12:25:35PM +0530, Sricharan Ramabadhran wrote:
>> PARF_SLV_ADDR_SPACE_SIZE_2_3_3 macro is used for IPQ8074
>> 2_3_3 post_init ops. PCIe slave addr size was initially set
>> to 0x358, but was wrongly changed to 0x168 as a part of
>> commit 39171b33f652 ("PCI: qcom: Remove PCIE20_ prefix from
>> register definitions"). Fixing it, by using the right macro
>> PARF_SLV_ADDR_SPACE_SIZE and remove the unused
>> PARF_SLV_ADDR_SPACE_SIZE_2_3_3.
> 
> Note, you do have a full 72 columns to use, no need to make it smaller.

  ok sure

> 
>> Without this pcie bring up on IPQ8074 is broken now.
> 
> I do not understand, something that used to work now breaks, or this is
> preventing a new chip from being "brought up"?
> 

  yes, ipq8074 pcie which was previously working is broken now.
  This patch fixes it.


Regards,
  Sricharan