linux-kernel - Re: [PATCH] hwmon: Explicitly include correct DT includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4b0115d-7a06-100c-ec77-027493c86206@roeck-us.net>
Date:   Mon, 17 Jul 2023 10:34:20 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Rob Herring <robh@...nel.org>
Cc:     Jean Delvare <jdelvare@...e.com>, Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Jean-Marie Verdun <verdun@....com>,
        Nick Hawkins <nick.hawkins@....com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Robert Marko <robert.marko@...tura.hr>,
        Saravanan Sekar <sravanhome@...il.com>,
        Luka Perkov <luka.perkov@...tura.hr>,
        Liviu Dudau <liviu.dudau@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        devicetree@...r.kernel.org, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH] hwmon: Explicitly include correct DT includes

On 7/17/23 10:24, Rob Herring wrote:
> On Sat, Jul 15, 2023 at 10:55 AM Guenter Roeck <linux@...ck-us.net> wrote:
>>
>> On Fri, Jul 14, 2023 at 11:46:04AM -0600, Rob Herring wrote:
>>> The DT of_device.h and of_platform.h date back to the separate
>>> of_platform_bus_type before it as merged into the regular platform bus.
>>> As part of that merge prepping Arm DT support 13 years ago, they
>>> "temporarily" include each other. They also include platform_device.h
>>> and of.h. As a result, there's a pretty much random mix of those include
>>> files used throughout the tree. In order to detangle these headers and
>>> replace the implicit includes with struct declarations, users need to
>>> explicitly include the correct includes.
>>>
>>> Signed-off-by: Rob Herring <robh@...nel.org>
>>
>> Applied to hwmon-next.
> 
> I found there's a double include of of.h in lm75.c. Can you fix that
> up or do you want me to send a fix?
> 

I fixed it up. Thanks a lot for noticing.

Guenter