linux-kernel - Re: [PATCH] ASoC: cs42l51: fix driver to properly autoload with automatic module loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2023 19:14:50 +0100
From:   Mark Brown <broonie@...nel.org>
To:     James Schulman <james.schulman@...rus.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] ASoC: cs42l51: fix driver to properly autoload with
 automatic module loading

On Thu, 13 Jul 2023 13:21:12 +0200, Thomas Petazzoni wrote:
> In commit 2cb1e0259f50 ("ASoC: cs42l51: re-hook of_match_table
> pointer"), 9 years ago, some random guy fixed the cs42l51 after it was
> split into a core part and an I2C part to properly match based on a
> Device Tree compatible string.
> 
> However, the fix in this commit is wrong: the MODULE_DEVICE_TABLE(of,
> ....) is in the core part of the driver, not the I2C part. Therefore,
> automatic module loading based on module.alias, based on matching with
> the DT compatible string, loads the core part of the driver, but not
> the I2C part. And threfore, the i2c_driver is not registered, and the
> codec is not known to the system, nor matched with a DT node with the
> corresponding compatible string.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs42l51: fix driver to properly autoload with automatic module loading
      commit: e51df4f81b02bcdd828a04de7c1eb6a92988b61e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark