linux-kernel - Re: [PATCH] regmap-irq: Set IRQCHIP_MASK_ON_SUSPEND if no wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56388e8a-dfc6-4fe7-8aa8-a4b69f201bd0@sirena.org.uk>
Date:   Mon, 17 Jul 2023 20:22:42 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Samuel Holland <samuel.holland@...ive.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Laxman Dewangan <ldewangan@...dia.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap-irq: Set IRQCHIP_MASK_ON_SUSPEND if no wake_base

On Mon, Jul 17, 2023 at 12:16:54PM -0700, Samuel Holland wrote:

> If hardware provides no way to control which IRQs are wakeup enabled,
> then software needs to mask non-wakeup-enabled IRQs when going to sleep.

This isn't an unambigiously clear statement, especially for MFDs where
there might be a desire to have some function on the device be able to
wake the system (eg, headset button press on an audio CODEC or a RTC on
a PMIC) even if there's no control within the device...

> Fixes: 55ac85e942c6 ("regmap: irq: enable wake support by default")

...as the commit log does hint at.  If there's a problem I think we need
some finer grained control here.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)