linux-kernel - Re: [PATCH net v3] net: bonding: Fix error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2413.1689623712@famine>
Date:   Mon, 17 Jul 2023 12:55:12 -0700
From:   Jay Vosburgh <jay.vosburgh@...onical.com>
To:     Tariq Toukan <ttoukan.linux@...il.com>
cc:     Wang Ming <machel@...o.com>, Andy Gospodarek <andy@...yhouse.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Yufeng Mo <moyufeng@...wei.com>,
        Guangbin Huang <huangguangbin2@...wei.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        opensource.kernel@...o.com, Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net v3] net: bonding: Fix error checking for debugfs_create_dir()

Tariq Toukan <ttoukan.linux@...il.com> wrote:
>On 17/07/2023 11:53, Wang Ming wrote:
>> The debugfs_create_dir() function returns error pointers,
>> it never returns NULL. Most incorrect error checks were fixed,
>> but the one in bond_create_debugfs() was forgotten.
>> Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
>
>It's not this commit to blame...
>Issue was there in first place, starting in commit f073c7ca29a4 ("bonding:
>add the debugfs facility to the bonding driver").

	Agreed; please upate the Fixes: commit and resubmit, thanks.

	-J

>
>> Signed-off-by: Wang Ming <machel@...o.com>
>> ---
>>   drivers/net/bonding/bond_debugfs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/drivers/net/bonding/bond_debugfs.c
>> b/drivers/net/bonding/bond_debugfs.c
>> index 594094526648..d4a82f276e87 100644
>> --- a/drivers/net/bonding/bond_debugfs.c
>> +++ b/drivers/net/bonding/bond_debugfs.c
>> @@ -88,7 +88,7 @@ void bond_create_debugfs(void)
>>   {
>>   	bonding_debug_root = debugfs_create_dir("bonding", NULL);
>>   -	if (!bonding_debug_root)
>> +	if (IS_ERR(bonding_debug_root))
>>   		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
>>   }
>>   

---
	-Jay Vosburgh, jay.vosburgh@...onical.com