linux-kernel - Re: [PATCH v4 3/6] mmc: sdhci-cadence: SD6 controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b236b46f-d6de-21f1-d535-680518a0b945@linaro.org>
Date:   Mon, 17 Jul 2023 22:04:50 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Piyush Malgujar <pmalgujar@...vell.com>, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, adrian.hunter@...el.com,
        ulf.hansson@...aro.org, p.zabel@...gutronix.de, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        yamada.masahiro@...ionext.com, devicetree@...r.kernel.org
Cc:     jannadurai@...vell.com, cchavva@...vell.com,
        Dhananjay Kangude <dkangude@...ence.com>
Subject: Re: [PATCH v4 3/6] mmc: sdhci-cadence: SD6 controller support

On 17/07/2023 14:51, Piyush Malgujar wrote:
> From: Dhananjay Kangude <dkangude@...ence.com>
> 
> Add support for SD6 controller for Marvell CN10k SoCs and related ops
> along with support for HS400 and HS400ES emmc modes.
> Updated HS200 tuning values and support to read tune configuration
> from FDT and support to configure and read host side drive strength,
> slew from device tree.
> 

...

>  static void sdhci_cdns_hs400_enhanced_strobe(struct mmc_host *mmc,
>  					     struct mmc_ios *ios)
>  {
> @@ -518,8 +1752,11 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
>  	struct sdhci_pltfm_host *pltfm_host;
>  	struct sdhci_cdns_priv *priv;
>  	struct clk *clk;
> +	bool sd6_ctrl;
>  	int ret;
>  	struct device *dev = &pdev->dev;
> +	sd6_ctrl = of_device_is_compatible(dev->of_node, "marvell,cdns-sd6hc");

Don't sprinkle compatibles in probe. You have match data for quirks and
flags.

> +
>  	static const u16 version = SDHCI_SPEC_400 << SDHCI_SPEC_VER_SHIFT;
>  

Best regards,
Krzysztof