linux-kernel - Re: [PATCH V1 3/5] ASoC: codecs: ACF bin parsing and check library file for aw88261

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98292541-8435-53cb-22d9-716ed6541485@linaro.org>
Date:   Mon, 17 Jul 2023 22:40:49 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     wangweidong.a@...nic.com, lgirdwood@...il.com, broonie@...nel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, perex@...ex.cz, tiwai@...e.com,
        rf@...nsource.cirrus.co, shumingf@...ltek.com,
        herve.codina@...tlin.com, flatmax@...tmax.com,
        ckeepax@...nsource.cirrus.com, doug@...morgal.com,
        fido_max@...ox.ru, pierre-louis.bossart@...ux.intel.com,
        kiseok.jo@...ndevice.com, liweilei@...nic.com,
        colin.i.king@...il.com, trix@...hat.com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     yijiangtao@...nic.com, zhangjianming@...nic.com
Subject: Re: [PATCH V1 3/5] ASoC: codecs: ACF bin parsing and check library
 file for aw88261

On 17/07/2023 13:58, wangweidong.a@...nic.com wrote:
> From: Weidong Wang <wangweidong.a@...nic.com>
> 
> The AW88261 is an I2S/TDM input, high efficiency
> digital Smart K audio amplifier with an integrated 10.25V
> smart boost convert

So all your commits are doing the same?

> 
> Signed-off-by: Weidong Wang <wangweidong.a@...nic.com>
> ---
>  sound/soc/codecs/aw88261/aw88261_lib.c | 997 +++++++++++++++++++++++++
>  sound/soc/codecs/aw88261/aw88261_lib.h |  91 +++
>  2 files changed, 1088 insertions(+)
>  create mode 100644 sound/soc/codecs/aw88261/aw88261_lib.c
>  create mode 100644 sound/soc/codecs/aw88261/aw88261_lib.h
> 
> diff --git a/sound/soc/codecs/aw88261/aw88261_lib.c b/sound/soc/codecs/aw88261/aw88261_lib.c
> new file mode 100644
> index 000000000000..b8f00708dacf
> --- /dev/null
> +++ b/sound/soc/codecs/aw88261/aw88261_lib.c
> @@ -0,0 +1,997 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +//
> +// aw88261_lib.c  -- ACF bin parsing and check library file for aw88261
> +//
> +// Copyright (c) 2023 awinic Technology CO., LTD
> +//
> +// Author: Jimmy Zhang <zhangjianming@...nic.com>
> +// Author: Weidong Wang <wangweidong.a@...nic.com>
> +//
> +
> +#include <linux/crc8.h>
> +#include <linux/i2c.h>
> +#include "aw88261_lib.h"
> +#include "aw88261_device.h"
> +
> +#define AW88261_CRC8_POLYNOMIAL 0x8C
> +DECLARE_CRC8_TABLE(aw_crc8_table);
> +
> +static char *profile_name[AW88261_PROFILE_MAX] = {

Cannot be const char *?

...

> +EXPORT_SYMBOL_GPL(aw88261_dev_load_acf_check);

Why?



Best regards,
Krzysztof