linux-kernel - Re: [PATCH v1 1/1] seq_file: Replace strncpy()+nul by strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202307171558.09183D81@keescook>
Date:   Mon, 17 Jul 2023 15:58:29 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] seq_file: Replace strncpy()+nul by strscpy()

On Mon, Jul 17, 2023 at 07:05:44PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 17, 2023 at 08:43:55AM -0700, Kees Cook wrote:
> > On Mon, Jul 17, 2023 at 12:33:32PM +0300, Andy Shevchenko wrote:
> 
> ...
> 
> > I think this doesn't need to use seq_show_option_n() at all.
> 
> Quite likely. Nevertheless, it's one of the dozens (?) warnings like this.
> 
> ...
> 
> > Reviewed-by: Kees Cook <keescook@...omium.org>
> 
> Thank you for the review!
> 
> I think it's you who may take it as seq_file.h seems everybody's playground.

Ah, good point. :P

-- 
Kees Cook