linux-kernel - Re: [PATCH] Bluetooth: hci_event: Ignore NULL link key in hci_link_key_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20230717055150.GO5866@linux-l9pv.suse>
Date:   Mon, 17 Jul 2023 13:51:50 +0800
From:   joeyli <jlee@...e.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Chun-Yi Lee <joeyli.kernel@...il.com>,
        linux-bluetooth@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] Bluetooth: hci_event: Ignore NULL link key in
 hci_link_key_notify_evt()

Hi Markus,

Thanks for your review!

On Fri, Jul 14, 2023 at 10:30:17PM +0200, Markus Elfring wrote:
> …
> > We can ignore null link key in the handler of "Link Key Notification
> > event" to relieve the attack. …
> 
> Are imperative change descriptions still preferred?
> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94
> 
> 
> How do you think about to add the tag “Fixes” because of
> an added case distinction?
>

Sorry for I didn't capture your point. The "Link Key Notification event" 
is a term in bluetooth-core spec. What should I change in my patch
description?

Thanks a lot!
Joey Le