Message-ID: <e6dd6f96-b422-419f-3649-631108ffc32a@intel.com>
Date:   Tue, 18 Jul 2023 07:38:15 +0800
From:   Yin Fengwei <fengwei.yin@...el.com>
To:     Zi Yan <ziy@...dia.com>
CC:     David Hildenbrand <david@...hat.com>, Yu Zhao <yuzhao@...gle.com>,
        Minchan Kim <minchan@...nel.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>, <akpm@...ux-foundation.org>,
        <willy@...radead.org>, <ryan.roberts@....com>,
        <shy828301@...il.com>,
        "Vishal Moola (Oracle)" <vishal.moola@...il.com>
Subject: Re: [RFC PATCH] madvise: make madvise_cold_or_pageout_pte_range()
 support large folio



On 7/17/23 22:38, Zi Yan wrote:
> On 16 Jul 2023, at 20:15, Yin, Fengwei wrote:
> 
>> On 7/14/2023 10:41 PM, Zi Yan wrote:
>>> On 14 Jul 2023, at 3:31, David Hildenbrand wrote:
>>>
>>>> On 14.07.23 05:23, Yu Zhao wrote:
>>>>> On Thu, Jul 13, 2023 at 9:10 PM Yin, Fengwei <fengwei.yin@...el.com> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> On 7/14/2023 10:08 AM, Yu Zhao wrote:
>>>>>>> On Thu, Jul 13, 2023 at 9:06 AM Yin Fengwei <fengwei.yin@...el.com> wrote:
>>>>>>>>
>>>>>>>> Current madvise_cold_or_pageout_pte_range() has two problems for
>>>>>>>> large folio support:
>>>>>>>>    - Using folio_mapcount() with large folio prevent large folio from
>>>>>>>>      picking up.
>>>>>>>>    - If large folio is in the range requested, shouldn't split it
>>>>>>>>      in madvise_cold_or_pageout_pte_range().
>>>>>>>>
>>>>>>>> Fix them by:
>>>>>>>>    - Use folio_estimated_sharers() with large folio
>>>>>>>>    - If large folio is in the range requested, don't split it. Leave
>>>>>>>>      to page reclaim phase.
>>>>>>>>
>>>>>>>> For large folio cross boundaries of requested range, skip it if it's
>>>>>>>> page cache. Try to split it if it's anonymous folio. If splitting
>>>>>>>> fails, skip it.
>>>>>>>
>>>>>>> For now, we may not want to change the existing semantic (heuristic).
>>>>>>> IOW, we may want to stick to the "only owner" condition:
>>>>>>>
>>>>>>>    - if (folio_mapcount(folio) != 1)
>>>>>>>    + if (folio_entire_mapcount(folio) ||
>>>>>>>    +     (any_page_within_range_has_mapcount > 1))
>>>>>>>
>>>>>>> +Minchan Kim
>>>>>> The folio_estimated_sharers() was discussed here:
>>>>>> https://lore.kernel.org/linux-mm/20230118232219.27038-6-vishal.moola@gmail.com/
>>>>>> https://lore.kernel.org/linux-mm/20230124012210.13963-2-vishal.moola@gmail.com/
>>>>>>
>>>>>> Yes. It's accurate to check each page of large folio. But it may be over killed in
>>>>>> some cases (And I think madvise is one of the cases not necessary to be accurate.
>>>>>> So folio_estimated_sharers() is enough. Correct me if I am wrong).
>>>>>
>>>>> I see. Then it's possible this is also what the original commit wants
>>>>> to do -- Minchan, could you clarify?
>>>>>
>>>>> Regardless, I think we can have the following fix, potentially cc'ing stable:
>>>>>
>>>>> -  if (folio_mapcount(folio) != 1)
>>>>> +  if (folio_estimated_sharers(folio) != 1)
>>>>>
>>>>> Sounds good?
>>>>
>>>> Adding to the discussion, currently the COW selftest always skips a PTE-mapped THP.
>>>>
>>>>
>>>> For example:
>>>>
>>>> # [INFO] Anonymous memory tests in private mappings
>>>> # [RUN] Basic COW after fork() ... with base page
>>>> ok 1 No leak from parent into child
>>>> # [RUN] Basic COW after fork() ... with swapped out base page
>>>> ok 2 No leak from parent into child
>>>> # [RUN] Basic COW after fork() ... with THP
>>>> ok 3 No leak from parent into child
>>>> # [RUN] Basic COW after fork() ... with swapped-out THP
>>>> ok 4 No leak from parent into child
>>>> # [RUN] Basic COW after fork() ... with PTE-mapped THP
>>>> ok 5 No leak from parent into child
>>>> # [RUN] Basic COW after fork() ... with swapped-out, PTE-mapped THP
>>>> ok 6 # SKIP MADV_PAGEOUT did not work, is swap enabled?
>>>> ...
>>>>
>>>>
>>>> The commit that introduced that change is:
>>>>
>>>> commit 07e8c82b5eff8ef34b74210eacb8d9c4a2886b82
>>>> Author: Vishal Moola (Oracle) <vishal.moola@...il.com>
>>>> Date:   Wed Dec 21 10:08:46 2022 -0800
>>>>
>>>>     madvise: convert madvise_cold_or_pageout_pte_range() to use folios
>>>>
>>>>     This change removes a number of calls to compound_head(), and saves
>>>>     1729 bytes of kernel text.
>>>>
>>>>
>>>>
>>>> folio_mapcount(folio) is wrong, because that never works on a PTE-mapped THP (well, unless only a single subpage is still mapped ...).
>>>>
>>>> page_mapcount(folio) was wrong, because it ignored all other subpages, but at least it worked in some cases.
>>>>
>>>> folio_estimated_sharers(folio) is similarly wrong like page_mapcount(), as it's essentially a page_mapcount() of the first subpage.
>>>>
>>>> (ignoring that a lockless mapcount-based check is always kind-of unreliable, but that's msotly acceptable for these kind of things)
>>>>
>>>>
>>>> So, unfortunately, page_mapcount() / folio_estimated_sharers() is best we can do for now, but they miss to detect some cases of sharing of the folio -- false negatives to detect sharing.
>>>>
>>>>
>>>> Ideally we want something like folio_maybe_mapped_shared(), and get rid of folio_estimated_sharers(), we better to guess the exact number, simply works towards an answer that tells us "yep, this may be mapped by multiple sharers" vs. "no, this is definitely not mapped by multiple sharers".
>>>>
>>>> The "mapped" part of it indicates that this does not catch all cases of sharing. But it should handle most of the cases we care about.
>>>>
>>>>
>>>> There, we can then implement something better than what folio_estimated_sharers() currently does:
>>>>
>>>> static inline bool folio_maybe_mapped_shared(folio)
>>>> {
>>>> 	if (likely(!folio_test_large(folio)))
>>>> 		return atomic_read(&folio->_mapcount) > 0;
>>>>
>>>> 	/* Mapped multiple times via PMD? */
>>>> 	if (folio_test_pmd_mappable(folio)
>>>> 		return folio_entire_mapcount() > 1;
>>>>
>>>> 	/*
>>>> 	 * First subpage is mapped multiple times (especially also via
>>>> 	 * PMDs)?
>>>>          */
>>>> 	if (page_mapcount(folio_page(folio, 0) > 1)
>>>> 		return true;
>>>>
>>>> 	/* TODO: also test last subpage? */
>>>> 	
>>>> 	/* Definitely shared if we're mapping a page multiple times. */
>>>> 	return folio_total_mapcount(folio) > folio_nr_pages(folio);
>>>> }
>>>>
>>>> There are some more things we could optimize for.
>>>
>>> Before jumping into the mapcount, I would like to get some clarification
>>> on "sharer". Does it mean a page is mapped/shared by more than one page
>>> table entry or is mapped/shared by more than one process? Your function
>>> indicates it is the former, but for madvise_cold_or_pageout_pte_range(),
>>> I am not sure that is what we want. What if user wants to page out a
>>> page that is mapped by the same process twice? With current method
>>> or any existing proposals, it will fail undesirably. It will only work
>>> as expect with your creator proposal[1].
>> My understanding here is more than one page table entry based on:
>>   - Original code use mapcount() for normal 4K page. It's for page table.
> Yes.
> 
>>   - If user wants to page out a page mapped to same process twice, maybe
>>     madvise_pageout() should be called twice for different mapping address.
> 
> That could be a reasonable way of handing it, but current code bails out
> once it finds a folio is mapped more than once. This means a process cannot
> page out any page mapped twice no matter if it is mapped to the same process
> or not. Maybe it is worth some clarification in the manpage for this behavior.
This is just a thought when I read this part of code. Especially for mapcount
constrain. Like if the mapcount is larger than 1, unmap the page from the
VMA requested by the syscall this time.

But I am lack of understanding to the user case of this syscall. So it may
be total wrong.

> 
> 
>>   - It has more chance to fail reclaiming if pages mapped twice in page
>>     table entry. And more chance to be faulted in again.
> Only if madvise_cold_or_pageout_pte_range() unmaps the page regardless of
> its mapcount.
This is just my guess why only handle mapcount ==1 case. 


Regards
Yin, Fengwei

> 
> 
> --
> Best Regards,
> Yan, Zi

Powered by blists - more mailing lists