linux-kernel - Re: [PATCH] proc: Fix four errors in kmsg.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <658bfc14-3819-8cf2-6e08-a9794c72f4c8@infradead.org>
Date:   Sun, 16 Jul 2023 23:08:31 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Sergey Senozhatsky <senozhatsky@...omium.org>, huzhi001@...suo.com,
        Petr Mladek <pmladek@...e.com>
Cc:     tglx@...utronix.de, adobriyan@...il.com, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] proc: Fix four errors in kmsg.c



On 7/16/23 23:05, Sergey Senozhatsky wrote:
> On (23/07/14 10:22), Petr Mladek wrote:
>> On Fri 2023-07-14 14:57:59, huzhi001@...suo.com wrote:
>>> The following checkpatch errors are removed:
>>> ERROR: "foo * bar" should be "foo *bar"
>>> ERROR: "foo * bar" should be "foo *bar"
>>> ERROR: "foo * bar" should be "foo *bar"
>>> ERROR: "foo * bar" should be "foo *bar"
>>
>> Please, do not do fix these cosmetic issues reported by checkpatch.pl.
>> It is not worth the effort. In fact, it is contra productive.
>> It complicates the git history, backports.
> 
> Absolutely agree with Petr.
> 
> As a side note, I wonder if checkpatch can deprecate that -f option?

Either that or document in very strong language that it should only be used
in very special circumstances, usually by the file owner or maintainer.

-- 
~Randy