linux-kernel - Re: [PATCH v2 7/7] PCI: endpoint: Add kernel-doc for pci_epc_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2023 00:04:48 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        lpieralisi@...nel.org, kw@...ux.com
Cc:     kishon@...nel.org, bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 7/7] PCI: endpoint: Add kernel-doc for
 pci_epc_mem_init() API



On 7/16/23 23:54, Manivannan Sadhasivam wrote:
> Add missing kernel-doc for pci_epc_mem_init() API.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

Looks good. Thanks.

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

> ---
>  drivers/pci/endpoint/pci-epc-mem.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/pci/endpoint/pci-epc-mem.c b/drivers/pci/endpoint/pci-epc-mem.c
> index 7dcf6f480b82..a9c028f58da1 100644
> --- a/drivers/pci/endpoint/pci-epc-mem.c
> +++ b/drivers/pci/endpoint/pci-epc-mem.c
> @@ -115,6 +115,16 @@ int pci_epc_multi_mem_init(struct pci_epc *epc,
>  }
>  EXPORT_SYMBOL_GPL(pci_epc_multi_mem_init);
>  
> +/**
> + * pci_epc_mem_init() - Initialize the pci_epc_mem structure
> + * @epc: the EPC device that invoked pci_epc_mem_init
> + * @base: Physical address of the window region
> + * @size: Total Size of the window region
> + * @page_size: Page size of the window region
> + *
> + * Invoke to initialize a single pci_epc_mem structure used by the
> + * endpoint functions to allocate memory for mapping the PCI host memory
> + */
>  int pci_epc_mem_init(struct pci_epc *epc, phys_addr_t base,
>  		     size_t size, size_t page_size)
>  {

-- 
~Randy