linux-kernel - Re: [PATCH v1] gfs2: increase usage of folio_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHc6FU4_SDSpom3Qvt35AXOmmc3v9EJYksgP4EN3owMEC2y-AA@mail.gmail.com>
Date:   Mon, 17 Jul 2023 09:42:23 +0200
From:   Andreas Gruenbacher <agruenba@...hat.com>
To:     Minjie Du <duminjie@...o.com>
Cc:     Bob Peterson <rpeterso@...hat.com>, cluster-devel@...hat.com,
        linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] gfs2: increase usage of folio_next_index() helper

Minjie,

On Mon, Jul 17, 2023 at 9:20 AM Minjie Du <duminjie@...o.com> wrote:
> Simplify code pattern of 'folio->index + folio_nr_pages(folio)' by using
> the existing helper folio_next_index().
>
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
>  fs/gfs2/aops.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
> index ae49256b7..5f0254237 100644
> --- a/fs/gfs2/aops.c
> +++ b/fs/gfs2/aops.c
> @@ -272,8 +272,7 @@ static int gfs2_write_jdata_batch(struct address_space *mapping,
>                                  * not be suitable for data integrity
>                                  * writeout).
>                                  */
> -                               *done_index = folio->index +
> -                                       folio_nr_pages(folio);
> +                               *done_index = folio_next_index(folio);
>                                 ret = 1;
>                                 break;
>                         }
> --
> 2.39.0
>

Applied, thanks.

Email addresses like '"open list:GFS2 FILE SYSTEM"
<cluster-devel@...hat.com>' and 'open list
<linux-kernel@...r.kernel.org>' are not helpful though, so could you
please avoid using addresses like that in the future?

Thanks,
Andreas