linux-kernel - Re: [PATCH] riscv: kernel: remove space before ')'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230717-gummy-frisbee-2f7dbe9f9512@wendy>
Date:   Mon, 17 Jul 2023 09:03:13 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     <hanyu001@...suo.com>
CC:     <paul.walmsley@...ive.com>, <palmer@...belt.com>,
        <aou@...s.berkeley.edu>, <liaochang1@...wei.com>,
        <heiko.stuebner@...ll.eu>, <linux-riscv@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] riscv: kernel: remove space before ')'

Hey,

On Mon, Jul 17, 2023 at 03:48:37PM +0800, hanyu001@...suo.com wrote:
> Fixes checkpatch errors:
> 
> riscv/kernel/probes:ERROR:space prohibited before that close parenthesis ')'
> riscv/kernel/probes:ERROR:space prohibited before that close parenthesis ')'
> riscv/kernel/probes:ERROR:space prohibited before that close parenthesis ')'
> 
> Signed-off-by: ztt <1549089851@...com>

Checkpatch complaints that this does not match the email you sent the
patch from. "ztt" is not a known identity either, so that's insufficient
for DCO purposes.

Thirdly, the patch is corrupted, with tabs replaced by spaces.
I've seen a lot of "checkpatch -f" fix patches from 208suo.com people
across various subsystems over the last few weeks that are all corrupted
and do not apply. Please don't send any more for arch/riscv until you
figure out how to send them without corruption.

Thanks,
Conor.

> ---
>  arch/riscv/kernel/probes/simulate-insn.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/riscv/kernel/probes/simulate-insn.c
> b/arch/riscv/kernel/probes/simulate-insn.c
> index 7441ac8a6843..60792c79b42e 100644
> --- a/arch/riscv/kernel/probes/simulate-insn.c
> +++ b/arch/riscv/kernel/probes/simulate-insn.c
> @@ -128,10 +128,10 @@ bool __kprobes simulate_auipc(u32 opcode, unsigned
> long addr, struct pt_regs *re
>      (((opcode) >> 12) & 0x7)
> 
>  #define branch_imm(opcode) \
> -    (((((opcode) >>  8) & 0xf ) <<  1) | \
> +    (((((opcode) >>  8) & 0xf) <<  1) | \
>       ((((opcode) >> 25) & 0x3f) <<  5) | \
> -     ((((opcode) >>  7) & 0x1 ) << 11) | \
> -     ((((opcode) >> 31) & 0x1 ) << 12))
> +     ((((opcode) >>  7) & 0x1) << 11) | \
> +     ((((opcode) >> 31) & 0x1) << 12))
> 
>  #define branch_offset(opcode) \
>      sign_extend32((branch_imm(opcode)), 12)

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)