[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <045467d8-1122-b1d3-07b6-bddd92bfa9b3@linaro.org>
Date: Mon, 17 Jul 2023 10:15:33 +0200
From: Philippe Mathieu-Daudé <philmd@...aro.org>
To: Rob Herring <robh@...nel.org>,
Rafał Miłecki <rafal@...ecki.pl>,
Florian Fainelli <florian.fainelli@...adcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>
Cc: devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: bcm: Explicitly include correct DT includes
Hi Rob,
On 14/7/23 19:51, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
"before it was"?
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> drivers/soc/bcm/bcm63xx/bcm-pmb.c | 1 -
> drivers/soc/bcm/bcm63xx/bcm63xx-power.c | 1 -
> 2 files changed, 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>
Powered by blists - more mailing lists