linux-kernel - RE: Fwd: [PATCH] arm: mm: replace snprintf in show functions with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9896a3f4009946dda3d0dcbc1d8e8f7a@AcuMS.aculab.com>
Date:   Mon, 17 Jul 2023 08:22:06 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Russell King' <linux@...linux.org.uk>,
        "hanyu001@...suo.com" <hanyu001@...suo.com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: Fwd: [PATCH] arm: mm: replace snprintf in show functions with
 sysfs_emit

From: Russell King <linux@...linux.org.uk>
> Sent: 13 July 2023 11:16
> To: hanyu001@...suo.com
> Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: Fwd: [PATCH] arm: mm: replace snprintf in show functions with sysfs_emit
> 
> On Thu, Jul 13, 2023 at 06:06:15PM +0800, hanyu001@...suo.com wrote:
> > coccicheck complains about the use of snprintf() in sysfs show functions.
> >
> > Fix the coccicheck warning:
> > WARNING: use scnprintf or sprintf.
> >
> > ./arch/arm/mm/cache-l2x0-pmu.c:346:8-16: WARNING: use scnprintf or sprintf
> >
> > Signed-off-by: ztt <1549089851@...com>
> > ---
> >  arch/arm/mm/cache-l2x0-pmu.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mm/cache-l2x0-pmu.c b/arch/arm/mm/cache-l2x0-pmu.c
> > index 993fefdc167a..d20626451a2e 100644
> > --- a/arch/arm/mm/cache-l2x0-pmu.c
> > +++ b/arch/arm/mm/cache-l2x0-pmu.c
> > @@ -343,7 +343,7 @@ static ssize_t l2x0_pmu_event_show(struct device *dev,
> >      struct l2x0_event_attribute *lattr;
> >
> >      lattr = container_of(attr, typeof(*lattr), attr);
> > -    return snprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
> > +    return scnprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
> 
> This only serves to shut up a warning. On 32-bit ARM, there is utterly
> no way what so ever that "config=0x%x\n" could ever overflow 4096 bytes,
> or even 32 bytes!

The code also doesn't match the commit message.
Did you actually send the correct copy of all these patches?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)