linux-kernel - Re: [PATCH v4 07/17] drm/imagination: Add GPU ID parsing and firmware loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd2daftonqrd6ae2pc6jlyw5zv4n4hhmzb5ifnrhb24kjpzecp@vk74clsdhy2l>
Date:   Mon, 17 Jul 2023 10:25:18 +0200
From:   Maxime Ripard <mripard@...nel.org>
To:     Sarah Walker <sarah.walker@...tec.com>
Cc:     dri-devel@...ts.freedesktop.org, frank.binns@...tec.com,
        donald.robson@...tec.com, boris.brezillon@...labora.com,
        faith.ekstrand@...labora.com, airlied@...il.com, daniel@...ll.ch,
        maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de, afd@...com,
        hns@...delico.com, matthew.brost@...el.com,
        christian.koenig@....com, luben.tuikov@....com, dakr@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 07/17] drm/imagination: Add GPU ID parsing and
 firmware loading

On Fri, Jul 14, 2023 at 03:27:00PM +0100, Sarah Walker wrote:
> +/**
> + * pvr_device_gpu_fini() - GPU-specific deinitialization for a PowerVR device
> + * @pvr_dev: Target PowerVR device.
> + */
> +static void
> +pvr_device_gpu_fini(struct pvr_device *pvr_dev)
> +{
> +	release_firmware(pvr_dev->fw_dev.firmware);
> +}
> +

Since you call that function at remove time, I think you can register a
devm action using devm_add_action_or_reset() to remove the need to call
it explicitly (and probably the need to have pvr_device_fini() in the
first place)

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)