[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c0f533a4-d196-649b-957e-eea6cd9e227c@starfivetech.com>
Date: Mon, 17 Jul 2023 16:35:28 +0800
From: Guo Samin <samin.guo@...rfivetech.com>
To: Rob Herring <robh@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
<netdev@...r.kernel.org>, Peter Geis <pgwipeout@...il.com>,
Frank <Frank.Sae@...or-comm.com>,
"David S . Miller" <davem@...emloft.net>,
"Eric Dumazet" <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Conor Dooley <conor@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Andrew Lunn <andrew@...n.ch>,
"Heiner Kallweit" <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
Yanhong Wang <yanhong.wang@...rfivetech.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: net: motorcomm: Add pad driver
strength cfg
-------- 原始信息 --------
主题: Re: [PATCH v4 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg
From: Rob Herring <robh@...nel.org>
收件人: Samin Guo <samin.guo@...rfivetech.com>
日期: 2023/7/15
> On Fri, Jul 14, 2023 at 06:14:05PM +0800, Samin Guo wrote:
>> The motorcomm phy (YT8531) supports the ability to adjust the drive
>> strength of the rx_clk/rx_data.
>>
>> The YT8531 RGMII LDO voltage supports 1.8V/3.3V, and the
>> LDO voltage can be configured with hardware pull-up resistors to match
>> the SOC voltage (usually 1.8V). The software can read the registers
>> 0xA001 obtain the current LDO voltage value.
>>
>> When we configure the drive strength, we need to read the current LDO
>> voltage value to ensure that it is a legal value at that LDO voltage.
>>
>> Reviewed-by: Hal Feng <hal.feng@...rfivetech.com>
>> Signed-off-by: Samin Guo <samin.guo@...rfivetech.com>
>> ---
>> .../bindings/net/motorcomm,yt8xxx.yaml | 46 +++++++++++++++++++
>> 1 file changed, 46 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
>> index 157e3bbcaf6f..097bf143af35 100644
>> --- a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
>> +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
>> @@ -52,6 +52,52 @@ properties:
>> for a timer.
>> type: boolean
>>
>> + motorcomm,rx-clk-driver-strength:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>
> As the units are uA, drop the type and add '-microamp' suffix.
> 'motorcomm,rx-clk-drv-microamp' is probably sufficient.
>
Thanks for the guidance, will be improved in the next version.
>> + description: |
>> + drive strength of rx_clk rgmii pad.
>> + |----------------------------------|
>> + | rx_clk ds map table |
>> + |----------------------------------|
>> + | DS(3b) | wol@...v | wol@...v |
>> + |________|_________________________|
>> + | | current(uA)| current(uA)|
>> + | 000 | 1200 | 3070 |
>> + | 001 | 2100 | 4080 |
>> + | 010 | 2700 | 4370 |
>> + | 011 | 2910 | 4680 |
>> + | 100 | 3110 | 5020 |
>> + | 101 | 3600 | 5450 |
>> + | 110 | 3970 | 5740 |
>> + | 111 | 4350 | 6140 |
>> + |--------|------------|------------|
>> + enum: [ 1200, 2100, 2700, 2910, 3070, 3110, 3600, 3970,
>> + 4080, 4350, 4370, 4680, 5020, 5450, 5740, 6140 ]
>> + default: 2910
>> +
>> + motorcomm,rx-data-driver-strength:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: |
>> + drive strength of rx_data/rx_ctl rgmii pad.
>> + |----------------------------------|
>> + | rx_data ds map table |
>> + |----------------------------------|
>> + | DS(3b) | wol@...v | wol@...v |
>> + |________|_________________________|
>> + | | current(uA)| current(uA)|
>> + | 000 | 1200 | 3070 |
>> + | 001 | 2100 | 4080 |
>> + | 010 | 2700 | 4370 |
>> + | 011 | 2910 | 4680 |
>> + | 100 | 3110 | 5020 |
>> + | 101 | 3600 | 5450 |
>> + | 110 | 3970 | 5740 |
>> + | 111 | 4350 | 6140 |
>> + |--------|------------|------------|
>> + enum: [ 1200, 2100, 2700, 2910, 3070, 3110, 3600, 3970,
>> + 4080, 4350, 4370, 4680, 5020, 5450, 5740, 6140 ]
>> + default: 2910
>> +
>> motorcomm,tx-clk-adj-enabled:
>> description: |
>> This configuration is mainly to adapt to VF2 with JH7110 SoC.
>> --
>> 2.17.1
>>
Best regards,
Samin
Powered by blists - more mailing lists