linux-kernel - Re: [PATCH v4 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68aacadd-f27d-76d3-36a1-78f5662ecb97@samsung.com>
Date:   Mon, 17 Jul 2023 20:26:48 +0900
From:   Jaewon Kim <jaewon02.kim@...sung.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>
Cc:     linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: pwm: samsung: add exynosautov9
 compatible


On 23. 7. 17. 19:59, Krzysztof Kozlowski wrote:
> On 17/07/2023 11:42, Jaewon Kim wrote:
>> Add samsung,exynosautov9-pwm compatible string to binding document.
>>
>> Signed-off-by: Jaewon Kim <jaewon02.kim@...sung.com>
>> ---
>>   .../devicetree/bindings/pwm/pwm-samsung.yaml     | 16 ++++++++++------
>>   1 file changed, 10 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
>> index fe603fb1b2cc..6f65e2b52f52 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
>> @@ -20,12 +20,16 @@ description: |+
>>   
>>   properties:
>>     compatible:
>> -    enum:
>> -      - samsung,s3c2410-pwm             # 16-bit, S3C24xx
>> -      - samsung,s3c6400-pwm             # 32-bit, S3C64xx
>> -      - samsung,s5p6440-pwm             # 32-bit, S5P64x0
>> -      - samsung,s5pc100-pwm             # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs
>> -      - samsung,exynos4210-pwm          # 32-bit, Exynos
>> +    oneOf:
>> +      - const: samsung,s3c2410-pwm        # 16-bit
>> +      - const: samsung,s3c6400-pwm        # 32-bit, S3C64xx
>> +      - const: samsung,s5p6440-pwm        # 32-bit, S5P64x0
>> +      - const: samsung,s5pc100-pwm        # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs
>> +      - const: samsung,exynos4210-pwm     # 32-bit, Exynos
> These are still an enum.
Okay I will change const to enum.
>
>> +      - items:
>> +          - enum:
>> +              - samsung,exynosautov9-pwm  # 32-bit, ExynosAutov9
> Let's drop the comment?

Should I just delete this comment or delete all comments in the 
enum(16-bit,S3C24xx, .....).

>
>> +          - const: samsung,exynos4210-pwm
>>   
> Best regards,
> Krzysztof
>
>

Thanks

Jaewon Kim